UI improvements and tarballs fix #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoWilken
force-pushed
the
tarballs+ui-improvements
branch
from
bfe0175
to
82ed30b
Compare
TimoWilken
force-pushed
the
tarballs+ui-improvements
branch
from
41abbc0
to
de261e0
Compare
Match the previous behaviour. On the first run through the loop, we haven't built the package yet, so the target paths might not exist yet.
This makes it easier to work out which packages are development packages without having to pass around the list of development packages separately.
This allows us to delay fetching tarballs, and avoid it completely if we already have the package installed. Also get rid of a pointless parameter (the package name is already set in the spec). To avoid re-fetching symlinks on every run, abort if we already have a matching one for any of our package's hashes. Previously, symlinks would not be re-fetched when a tarball was available, but now we might not have a tarball, even if the package in question is already installed.
Use ProgressPrint to show how far along we are while downloading precompiled tarballs from the remote.
Get rid of the spammy output when not in debug mode, instead showing a progress bar.
TimoWilken
force-pushed
the
tarballs+ui-improvements
branch
from
de261e0
to
56d52f5
Compare
|
Squashed and rebased @ktf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
ProgressPrintProgressPrint(in non-debug mode)Also contains one cleanup/refactoring commit (4236ab3) -- let me know if you want a separate PR for that one.