Clone SOURCES repos outside container #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoWilken
force-pushed
the
git-checkout-outside-container
branch
4 times, most recently
from
5a110f9
to
c726642
Compare
|
Rebased on #834. Only the last two commits are actually new! |
TimoWilken
added a commit
to TimoWilken/ali-bot
that referenced
this pull request
Mar 6, 2024
With alisw/alibuild#835, all git repos are created outside the aliBuild container, so we don't need to pass credentials inside anymore.
TimoWilken
added a commit
to TimoWilken/docks
that referenced
this pull request
Mar 6, 2024
This was originally needed because the default git did not support the `GIT_*` environment variables used by the CI. With alisw/alibuild#835 and alisw/ali-bot#1298, this is not needed anymore, so we can stop installing the extra copy of Git.
This lets us always use speed-up options like --filter, even when we're building inside a container. We can also easily start using sapling for this in future by implementing the new SCM methods. This also helps with some annoying authentication-related issues, if running inside --docker, such as in CI. Fixes <https://its.cern.ch/jira/browse/O2-2439>. When this is merged, we can also get rid of the `GIT_*` environment variables used in CI, and stop installing an especially-new Git version in our containers (since that was needed to understand the `GIT_*` variables).
TimoWilken
force-pushed
the
git-checkout-outside-container
branch
from
c726642
to
f68fcde
Compare
|
Rebased and all green @ktf! |
|
As discussed, let's have a prerelease and try it out in one of the non-production CIs. |
|
I've released v1.17.0rc1 and set the Ubuntu alidist CI to use it in alisw/ali-bot@56ec67d! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us always use speed-up options like
--filter, even when we're building inside a container.We can also easily start using sapling for this in future by implementing the new SCM methods.
This also helps with some annoying authentication-related issues, if running inside
--docker, such as in CI.Fixes https://its.cern.ch/jira/browse/O2-2439.
When this is merged, we can also get rid of the
GIT_*environment variables used in CI, and stop installing an especially-new Git version in our containers (since that was needed to understand theGIT_*variables).This PR is based on #834; once that is merged, I can rebase to get rid of the common commits.