Set text colour for radios divider #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
force-pushed
the
missing-text-colour
branch
2 times, most recently
from
22c9f44
to
98601cf
Compare
When testing component isolation on GOV.UK we noticed that text colour isn't applied to a radios__divider and instead it inherits this value. I'm assuming this behaviour isn't intentional as all the neighbouring fieldset components all have a colour set.
36degrees
approved these changes
Oct 8, 2018
|
Thanks @36degrees fyi I don't have write access so will need someone to hit the merge button for me |
|
Sorry, I should have said – for contributions outside of the team we require reviews from two different people, so this'll get merged once someone else has had a chance to review it 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋, I've enjoyed digging into some bits of GOV.UK Frontend over this firebreak, and I think I found a bug (or I don't properly understand isolation principles)
When testing component isolation on GOV.UK we noticed that text colour isn't applied to a radios_divider and instead it inherits this value. I'm assuming this behaviour isn't intentional as all the neighbouring fieldset components all have a colour set.