Clarify productName vs serviceName #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the minute the serviceName description incorrectly duplicates the productName description. In most cases, we expect people to use service name, so this is an attempt to clarify what each is for and when to use them.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1368
|
I know this is merged, and I don't know if it's helpful - but my service has opted to use |
|
Arguably Verify and Pay are verbs.. they all become common nouns if we use them to name products, but they are verbs at origin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the minute the serviceName description incorrectly duplicates the productName description.
In most cases, we expect people to use service name, so this is an attempt to clarify what each is for and when to use them.
Fixes #1286