Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify productName vs serviceName #1368

Merged
merged 2 commits into from
May 22, 2019
Merged

Clarify productName vs serviceName #1368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe7e679
Clarify productName vs serviceName
36degrees May 21, 2019
687d728
Document in CHANGELOG
36degrees May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,13 @@

([PR #1310](https://github.com/alphagov/govuk-frontend/pull/1310))

- Fixes the description for serviceName option in header component (used in the
GOV.UK Design System)

Thanks to [Ed Horsford](https://github.com/edwardhorsford) for reporting.

([PR #1368](https://github.com/alphagov/govuk-frontend/pull/1368))

[compatibility mode]: https://github.com/alphagov/govuk-frontend/blob/master/docs/installation/installing-with-npm.md#compatibility-mode

## 2.11.0 (Feature release)
Expand Down
4 changes: 2 additions & 2 deletions src/components/header/header.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ params:
- name: productName
type: string
required: false
description: Header title that is placed next to GOV.UK. Used for product names (i.e. Pay, Verify)
description: Product name, used when the product name follows on directly from ‘GOV.UK’. For example, GOV.UK Pay or GOV.UK Design System. In most circumstances, you should use serviceName.
- name: serviceName
type: string
required: false
description: Header title that is placed next to GOV.UK. Used for product names (i.e. Pay, Verify)
description: The name of your service, included in the header.
- name: serviceUrl
type: string
required: false
Expand Down