Update error messages to use paragraph tags instead of spans #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2083 Updates the error messages parent element to use paragraph tags instead of spans, as it's more semantically correct.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2452
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2452
vanitabarrett
changed the title
vanitabarrett
force-pushed
the
error-messages-paragraphs
branch
from
4feca6d
to
555d3e0
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2452
lfdebrux
previously approved these changes
Dec 3, 2021
Yep, good catch. I think there's an additional top margin coming from the user agent default styles for paragraphs? |
Switching the error message to a paragraph means that it gets any default browser styles for paragraphs applied. Looking at https://browserdefaultstyles.com/#p this seems to be margin-top and margin-bottom. We already set margin-bottom on the error message. This commit makes sure we set `margin-top` to `0` to reset any browser styles.
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2452
|
I've done a visual inspection in:
|
|
As a note, @lfdebrux has also spotted that this slightly changes how this component looks when styles are disabled. As it's now a paragraph, the error message renders on its own line, but we think this is an improvement. Before
After
|
4 tasks
Merged
peteryates
added a commit
to x-govuk/govuk-form-builder
that referenced
this pull request
Dec 18, 2021
Previously they were in spans but in version 4.0.0 of the design system p is preferred because it's more semantically correct alphagov/govuk-frontend#2452
andymantell
added a commit
to surevine/govuk-react-jsx
that referenced
this pull request
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2083
Updates the error messages parent element to use paragraph tags instead of spans, as it's more semantically correct.
Read #2083 (comment) for full details of accessibility testing. There should be no visual difference following this change.