Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change span to <p> in error message options #3879

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Change span to <p> in error message options #3879

merged 1 commit into from
Jul 3, 2023

Conversation

matteason
Copy link
Contributor

In 4.0.0, error messages were changed from <span>s to <p>s, but the macro documentation still references spans. This fixes those references

@colinrotherham colinrotherham added the awaiting triage Needs triaging by team label Jun 30, 2023
querkmachine
querkmachine approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@querkmachine querkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible to me. Just needs a second approval from someone on the team before we can merge.

@owenatgov owenatgov added 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) nunjucks documentation User requests new documentation or improvements to existing documentation and removed awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) nunjucks labels Jul 3, 2023
@owenatgov owenatgov added this to the v5.0 milestone Jul 3, 2023
owenatgov
owenatgov approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks sensible to me too. Thanks @matteason!

@owenatgov owenatgov merged commit 261b7e7 into alphagov:main Jul 3, 2023
25 checks passed
@matteason matteason deleted the patch-1 branch July 3, 2023 10:02
colinrotherham pushed a commit that referenced this pull request Jul 19, 2023
@owenatgov
Merge pull request #3879 from matteason/patch-1
4c61de1 
Change span to <p> in error message options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@querkmachine querkmachine querkmachine approved these changes

@owenatgov owenatgov owenatgov approved these changes

Assignees
No one assigned
Labels
documentation User requests new documentation or improvements to existing documentation
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matteason @querkmachine @owenatgov @colinrotherham