Fix ClusterClaim deletion webhook bug #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After K8s 1.16, the req.Object in deletion request is empty, only req.OldObject will be fulfilled, so change the ClusterClaim webhook to decode OldObject if it's deletion operation. This will fix a bug that ClusterCliam is unable to be deleted with below errors: ``` Error from server: error when deleting "clusterclaims.yaml": admission webhook "vclusterclaim.kb.io" denied the request: there is no content to decode ``` Signed-off-by: Lan Luo <luola@vmware.com>
|
/test-multicluster-e2e |
|
@jianjuns could you help to review this PR? I think we need backport this fix. Thanks. |
jianjuns
approved these changes
Jun 6, 2023
|
We do not have test to cover such basic deletion case? |
|
Yeah, unit test covered deletion but it used the wrong Object to fake data, so this issue is not found. |
|
/skip-all |
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After K8s 1.16, the req.Object in a deletion request is empty, and only req.OldObject will be provided, so change the ClusterClaim webhook to decode OldObject if it is a deletion operation.
This will fix a bug that ClusterCliam is unable to be deleted with the below error: