Promote Egress API to v1beta1 #5180

wenqiq · 2023-06-27T09:24:00Z

Promote Egress API to v1beta1

wenqiq · 2023-06-28T03:30:41Z

Some e2e test cases failed, seems not related to this change.
--- FAIL: TestBatchCreatePods https://github.com/antrea-io/antrea/actions/runs/5396462521/jobs/9800222909
--- FAIL: TestAntreaPolicy/TestGroupDefaultDENY/Case=ACNPPriorityOverrideDefaultDeny https://github.com/antrea-io/antrea/actions/runs/5396462521/jobs/9800223145

build/charts/antrea/crds/egress.yaml

docs/api.md

luolanzone · 2023-07-07T10:07:07Z

docs/api.md

 | `ClusterGroup` | v1alpha2 | v1.0.0 | v1.1.0 | v1.12.0 [^1] |
+| `Egress`       | v1alpha2 | v1.0.0 | v1.13.0 | v2.0.0 |


If we follow the K8s deprecation policy, we may not be able to remove it in v2.0.0 considering Egress feature gate is already beta, @antoninbas @tnqn any comment?

luolanzone · 2023-07-18T07:46:04Z

@wenqiq please resolve conflicts.

docs/api.md

build/charts/antrea/crds/egress.yaml

tnqn · 2023-07-20T09:56:38Z

pkg/apis/crd/v1beta1/types.go

+type AppliedTo struct {
+	// Select Pods matched by this selector. If set with NamespaceSelector,
+	// Pods are matched from Namespaces matched by the NamespaceSelector;
+	// otherwise, Pods are matched from all Namespaces.
+	// +optional
+	PodSelector *metav1.LabelSelector `json:"podSelector,omitempty"`
+	// Select all Pods from Namespaces matched by this selector. If set with
+	// PodSelector, Pods are matched from Namespaces matched by the
+	// NamespaceSelector.
+	// +optional
+	NamespaceSelector *metav1.LabelSelector `json:"namespaceSelector,omitempty"`
+	// Groups is the set of ClusterGroup names.
+	// +optional
+	Groups []string `json:"groups,omitempty"`
+}


This struct is shared with NetworkPolicy which contains more fields. Perhaps #5186 should be merged first as it contains the complete version of the struct.

I will rebase after this PR is merged.

tnqn · 2023-07-25T04:10:48Z

NetworkPolicy API upgrade has been merged, this PR can rebase on it.

tnqn

There are many failing checks, please check.

tnqn · 2023-07-25T05:57:45Z

test/e2e/traceflow_test.go

@@ -23,6 +23,8 @@ import (
 	"testing"
 	"time"

+	_ "github.com/golang/mock/mockgen/model"


why is it required?

Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>

wenqiq · 2023-07-25T07:31:41Z

/test-all

wenqiq · 2023-07-26T01:11:07Z

/test-e2e

wenqiq · 2023-07-26T03:37:01Z

=== RUN   TestL7NetworkPolicy/HTTP
=== RUN   TestL7NetworkPolicy/HTTP/Ingress
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-path-hostname
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-any-path
=== RUN   TestL7NetworkPolicy/HTTP/Egress
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-path-hostname
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-any-path
=== RUN   TestL7NetworkPolicy/TLS
    l7networkpolicy_test.go:122: Creating ANNP test-l7-tls-allow-sni-google
    l7networkpolicy_test.go:122: Creating ANNP test-l7-tls-allow-sni-facebook
    l7networkpolicy_test.go:174: 
        	Error Trace:	/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:174
        	            				/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:322
        	            				/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:61
        	Error:      	Received unexpected error:
        	            	command terminated with exit code 1
        	Test:       	TestL7NetworkPolicy/TLS
I0726 02:25:19.559981    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:19.638406    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-mcvwt'
I0726 02:25:19.895082    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:19.990680    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-txq6q'
I0726 02:25:20.249281    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:20.318942    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-wwj7v'
=== CONT  TestL7NetworkPolicy
    fixtures.go:317: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestL7NetworkPolicy/beforeTeardown.Jul26-02-25-33'
    fixtures.go:488: Deleting 'testl7networkpolicy-fsoidztp' K8s Namespace
I0726 02:25:36.691274    8448 framework.go:737] Deleting Namespace testl7networkpolicy-fsoidztp took 8.669341ms
--- FAIL: TestL7NetworkPolicy (92.05s)
    --- PASS: TestL7NetworkPolicy/HTTP (25.83s)
        --- PASS: TestL7NetworkPolicy/HTTP/Ingress (8.87s)
        --- PASS: TestL7NetworkPolicy/HTTP/Egress (8.93s)
    --- FAIL: TestL7NetworkPolicy/TLS (30.75s)

https://github.com/antrea-io/antrea/actions/runs/5653493868/job/15345762746?pr=5180

hongliangl · 2023-07-26T09:32:48Z

=== RUN   TestL7NetworkPolicy/HTTP
=== RUN   TestL7NetworkPolicy/HTTP/Ingress
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-path-hostname
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-any-path
=== RUN   TestL7NetworkPolicy/HTTP/Egress
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-path-hostname
    l7networkpolicy_test.go:122: Creating ANNP test-l7-http-allow-any-path
=== RUN   TestL7NetworkPolicy/TLS
    l7networkpolicy_test.go:122: Creating ANNP test-l7-tls-allow-sni-google
    l7networkpolicy_test.go:122: Creating ANNP test-l7-tls-allow-sni-facebook
    l7networkpolicy_test.go:174: 
        	Error Trace:	/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:174
        	            				/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:322
        	            				/home/runner/work/antrea/antrea/test/e2e/l7networkpolicy_test.go:61
        	Error:      	Received unexpected error:
        	            	command terminated with exit code 1
        	Test:       	TestL7NetworkPolicy/TLS
I0726 02:25:19.559981    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:19.638406    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-mcvwt'
I0726 02:25:19.895082    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:19.990680    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-txq6q'
I0726 02:25:20.249281    8448 framework.go:2553] Sending SIGINT to 'antrea-agent-coverage'
I0726 02:25:20.318942    8448 framework.go:2559] Copying coverage files from Pod 'antrea-agent-wwj7v'
=== CONT  TestL7NetworkPolicy
    fixtures.go:317: Exporting test logs to '/home/runner/work/antrea/antrea/log/TestL7NetworkPolicy/beforeTeardown.Jul26-02-25-33'
    fixtures.go:488: Deleting 'testl7networkpolicy-fsoidztp' K8s Namespace
I0726 02:25:36.691274    8448 framework.go:737] Deleting Namespace testl7networkpolicy-fsoidztp took 8.669341ms
--- FAIL: TestL7NetworkPolicy (92.05s)
    --- PASS: TestL7NetworkPolicy/HTTP (25.83s)
        --- PASS: TestL7NetworkPolicy/HTTP/Ingress (8.87s)
        --- PASS: TestL7NetworkPolicy/HTTP/Egress (8.93s)
    --- FAIL: TestL7NetworkPolicy/TLS (30.75s)

https://github.com/antrea-io/antrea/actions/runs/5653493868/job/15345762746?pr=5180

The failure of test is not introduced by your PR.

tnqn · 2023-07-26T12:33:04Z

/test-all

tnqn

LGTM

wenqiq force-pushed the egress-api-promotion branch from 30616a2 to 941941f Compare June 27, 2023 09:26

wenqiq mentioned this pull request Jun 28, 2023

[Antrea 2.0] Promote APIs to appropriate versions and feature gates to appropriate stages #5068

Closed

27 tasks

wenqiq force-pushed the egress-api-promotion branch from 20c4f90 to 1b45078 Compare June 28, 2023 02:06

wenqiq marked this pull request as ready for review June 28, 2023 02:53

wenqiq force-pushed the egress-api-promotion branch from 1b45078 to ee20497 Compare June 28, 2023 03:32

luolanzone added api-review Categorizes an issue or PR as actively needing an API review. action/release-note Indicates a PR that should be included in release notes. labels Jun 28, 2023

luolanzone added this to the Antrea v1.13 release milestone Jul 4, 2023

luolanzone reviewed Jul 7, 2023

View reviewed changes

luolanzone reviewed Jul 18, 2023

View reviewed changes

docs/api.md Show resolved Hide resolved

wenqiq force-pushed the egress-api-promotion branch 4 times, most recently from 8baf969 to 75860af Compare July 20, 2023 04:03

tnqn reviewed Jul 20, 2023

View reviewed changes

wenqiq force-pushed the egress-api-promotion branch from 75860af to 65e63e8 Compare July 21, 2023 01:14

wenqiq force-pushed the egress-api-promotion branch from 65e63e8 to a6dfdce Compare July 25, 2023 05:23

tnqn reviewed Jul 25, 2023

View reviewed changes

wenqiq force-pushed the egress-api-promotion branch from a6dfdce to 781be6a Compare July 25, 2023 06:02

Promote Egress API to v1beta1

5b00e44

Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>

wenqiq force-pushed the egress-api-promotion branch from 781be6a to 5b00e44 Compare July 25, 2023 06:13

Values of matchLabels in egress yaml validated with a pattern

77c2361

Signed-off-by: Wenqi Qiu <wenqiq@vmware.com>

tnqn approved these changes Jul 26, 2023

View reviewed changes

tnqn merged commit 876d81b into antrea-io:main Jul 26, 2023
42 of 43 checks passed

wenqiq deleted the egress-api-promotion branch July 26, 2023 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote Egress API to v1beta1 #5180

Promote Egress API to v1beta1 #5180

wenqiq commented Jun 27, 2023

wenqiq commented Jun 28, 2023

luolanzone Jul 7, 2023

luolanzone commented Jul 18, 2023

tnqn Jul 20, 2023

wenqiq Jul 21, 2023

tnqn commented Jul 25, 2023

tnqn left a comment

tnqn Jul 25, 2023

wenqiq commented Jul 25, 2023

wenqiq commented Jul 26, 2023

wenqiq commented Jul 26, 2023

hongliangl commented Jul 26, 2023

tnqn commented Jul 26, 2023

tnqn left a comment

		\| `ClusterGroup` \| v1alpha2 \| v1.0.0 \| v1.1.0 \| v1.12.0 [^1] \|
		\| `Egress` \| v1alpha2 \| v1.0.0 \| v1.13.0 \| v2.0.0 \|

Promote Egress API to v1beta1 #5180

Promote Egress API to v1beta1 #5180

Conversation

wenqiq commented Jun 27, 2023

wenqiq commented Jun 28, 2023

luolanzone Jul 7, 2023

Choose a reason for hiding this comment

luolanzone commented Jul 18, 2023

tnqn Jul 20, 2023

Choose a reason for hiding this comment

wenqiq Jul 21, 2023

Choose a reason for hiding this comment

tnqn commented Jul 25, 2023

tnqn left a comment

Choose a reason for hiding this comment

tnqn Jul 25, 2023

Choose a reason for hiding this comment

wenqiq commented Jul 25, 2023

wenqiq commented Jul 26, 2023

wenqiq commented Jul 26, 2023

hongliangl commented Jul 26, 2023

tnqn commented Jul 26, 2023

tnqn left a comment

Choose a reason for hiding this comment