Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ACNP and ANNP to v1beta1 #5186

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Upgrade ACNP and ANNP to v1beta1 #5186

merged 2 commits into from
Jul 25, 2023

Conversation

GraysonWu
Copy link
Contributor

@GraysonWu GraysonWu commented Jun 29, 2023

Given the limited nature of the changes between the 2 API
versions, use None conversion strategy.

@luolanzone luolanzone added action/release-note Indicates a PR that should be included in release notes. api-review Categorizes an issue or PR as actively needing an API review. labels Jun 29, 2023
@luolanzone luolanzone added this to the Antrea v1.13 release milestone Jul 4, 2023
@luolanzone
Copy link
Contributor

@GraysonWu please resolve code conflicts.

@GraysonWu
Copy link
Contributor Author

@GraysonWu please resolve code conflicts.

Hi @luolanzone, when PR #5181 is merged, I may need to resolve conflicts again. I will rebase after that PR is merged. In the meantime, let's start to review only the last commit about this PR.

build/charts/antrea/crds/networkpolicy.yaml Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@GraysonWu GraysonWu force-pushed the np-upgrade branch 6 times, most recently from b931b2a to d3e507b Compare July 22, 2023 21:07
Signed-off-by: graysonwu <wgrayson@vmware.com>
tnqn
tnqn previously approved these changes Jul 24, 2023
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

docs/api.md Outdated Show resolved Hide resolved
Signed-off-by: graysonwu <wgrayson@vmware.com>
@GraysonWu
Copy link
Contributor Author

/test-all
/test-multicluster-e2e

@GraysonWu GraysonWu requested a review from tnqn July 25, 2023 04:03
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit bef3711 into antrea-io:main Jul 25, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes. api-review Categorizes an issue or PR as actively needing an API review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants