-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ACNP and ANNP to v1beta1 #5186
Conversation
@GraysonWu please resolve code conflicts. |
Hi @luolanzone, when PR #5181 is merged, I may need to resolve conflicts again. I will rebase after that PR is merged. In the meantime, let's start to review only the last commit about this PR. |
b931b2a
to
d3e507b
Compare
Signed-off-by: graysonwu <wgrayson@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment
Signed-off-by: graysonwu <wgrayson@vmware.com>
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Given the limited nature of the changes between the 2 API
versions, use None conversion strategy.