feat: support aws secret manager #11417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuanXin-Chen
changed the title
moonming
reviewed
Jul 26, 2024
bzp2010
reviewed
Aug 1, 2024
bzp2010
reviewed
Aug 6, 2024
nic-6443
reviewed
Aug 22, 2024
nic-6443
reviewed
Aug 22, 2024
nic-6443
reviewed
Aug 22, 2024
HuanXin-Chen
dismissed stale reviews from membphis, bzp2010, and moonming
via
cb26bb8
nic-6443
previously approved these changes
Aug 25, 2024
bzp2010
previously approved these changes
Aug 25, 2024
moonming
previously approved these changes
Aug 27, 2024
membphis
previously approved these changes
Aug 27, 2024
t/secret/aws.t
Outdated
|
|
||
| local secret = require("apisix.secret") | ||
| local value = secret.fetch_by_uri("$secret://aws/mysecret/jack/key") | ||
| ngx.say(value) |
There was a problem hiding this comment.
Just confirm, it will print a nil value in this test case?
And it will be considered as expected output, it make me little confused
I prefer this way:
if value then
ngx.say("secret value: ", value)
end
ngx.say("all done")
apisix/secret/aws.lua
Outdated
| return data[sub_key] | ||
| end | ||
|
|
||
| _M.get = get |
There was a problem hiding this comment.
if we need to reuse the function get, the current style is good.
In this code, we do not need to reuse function get, so _M.get is better to read and understand
HuanXin-Chen
dismissed stale reviews from membphis, moonming, bzp2010, and nic-6443
via
b9d317c
bzp2010
approved these changes
Aug 27, 2024
moonming
approved these changes
Aug 27, 2024
nic-6443
approved these changes
Aug 28, 2024
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many enterprises are utilizing cloud services from AWS and GCP, relying on the secret manager provided by these platforms to handle sensitive information. Integrating Apache APISIX with these secret managers can streamline the process of using sensitive information within APISIX, enabling users to manage and utilize cloud-stored sensitive data more conveniently, thus enhancing the overall security and usability of the system.
This PR has completed the support for AWS. It added the aws.lua file to the original secret module, allowing users to store their secret information on AWS using the same reference method as before.
Checklist