Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-526] Upgrade to parent 39 #175

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 10, 2023

Requires #176

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@psiroky
Copy link
Contributor

psiroky commented Feb 10, 2023

Yes, please! Thank you for this change. <personalRant> the old style was really hurting my eyes </personalRant>

@gnodet gnodet force-pushed the parent-39 branch 3 times, most recently from 3acaf64 to afe3c99 Compare February 10, 2023 13:57
# Conflicts:
#	src/test/java/org/apache/maven/plugin/compiler/CompilerMojoTestCase.java
@gnodet gnodet merged commit f7a4613 into apache:master Feb 13, 2023
@gnodet gnodet added this to the 3.11.0 milestone Feb 13, 2023
@gnodet gnodet deleted the parent-39 branch February 14, 2023 07:29
@gnodet gnodet added the dependencies Pull requests that update a dependency file label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants