Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-523] Test with Maven 3.9.0 and fix the failing IT #176

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 10, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet gnodet marked this pull request as draft February 10, 2023 10:07
@@ -30,4 +30,4 @@ jobs:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "adopt-openj9" ]'
jdk-matrix: '[ "8", "11", "17", "18" ]' # "19-ea"
matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"},{ "jdk": "19-ea", "distribution": "microsoft"},{ "jdk": "18", "distribution": "microsoft"},{ "jdk": "19-ea", "distribution": "adopt-openj9"},]'
maven-matrix: '[ "3.3.9", "3.6.3", "3.8.6" ]' # Maven versions matrix for verify builds
maven-matrix: '[ "3.3.9", "3.6.3", "3.8.6", "3.9.0", "4.0.0-alpha-4" ]' # Maven versions matrix for verify builds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this commit (sorry for intruding):

  • Should we also build with JDK 19 rather than 18? E.g. use the latest stable JDK?
  • And maybe build with 3.8.7 instead of 3.8.6?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe get rid of 3.6.3?
and agree on removing 18 and replace with 19 (maybe 20-ea if exists?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should test LTS versions + latest.
I'll use this PR to fix the failing IT too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though changing the supported JDK may require some additional matrix exclusions, so we may want to tackle that in a different PR, I'll focus on maven versions + fixing the IT for now.

@gnodet gnodet changed the title Check more maven versions [MCOMPILER-523] Test with Maven 3.9.0 and fix the failing IT Feb 10, 2023
@gnodet gnodet marked this pull request as ready for review February 10, 2023 11:58
@psiroky
Copy link
Contributor

psiroky commented Feb 10, 2023

Looks good to me ( I can't of course formally approve or so).

@gnodet gnodet requested a review from olamy February 10, 2023 13:05
@gnodet gnodet mentioned this pull request Feb 10, 2023
8 tasks
@gnodet gnodet merged commit f9b6bd0 into apache:master Feb 10, 2023
@gnodet gnodet added this to the 3.11.0 milestone Feb 14, 2023
@gnodet gnodet deleted the more-maven branch February 14, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants