[MNG-7743] Make the build work on JDK 20 #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the behaviour before the fix was already pretty confusing. JDK 19 and
older do not check the presense of '{' in the constructor, so the
URL object got created, but when converting to file the result would
be e.g. '/../../src/test/remote-repo' which is completely wrong.
But it seems the affected tests did not really care, as all of them
were passing
psiroky
commented
Mar 18, 2023
| } catch (MalformedURLException e) { | ||
| throw new IllegalStateException(e); | ||
| String repositoryUrl = repository.getUrl(); | ||
| if (repositoryUrl.contains("${")) { |
There was a problem hiding this comment.
This is somewhat ugly, but I haven't really found a better way at this point (without some major changes in how the TestRepositoryConnector is being used}.
Basically either the TestRepositoryConnector would need to resolve the properties in the URL, or the constructor would have to be called with a RemoteRepository object which already has these resolved.
The single test that was failing (ProjectBuilderTest.testLocationTrackingResolution) does not really care about the location as far as I can tell.
yeikel
reviewed
Mar 21, 2023
maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yeikel <email@yeikel.com>
gnodet
approved these changes
Apr 19, 2023
slachiewicz
approved these changes
Apr 29, 2023
|
If you have some time would be good to backport it also |
gnodet
pushed a commit
that referenced
this pull request
May 16, 2023
* [MNG-7743] Make the build work on JDK 20 * the behaviour before the fix was already pretty confusing. JDK 19 and older do not check the presense of '{' in the constructor, so the URL object got created, but when converting to file the result would be e.g. '/../../src/test/remote-repo' which is completely wrong. But it seems the affected tests did not really care, as all of them were passing * Remove forgotten println Co-authored-by: Yeikel <email@yeikel.com> * Test with latest JDK * Do not run ITs with jdk 20, but just the "build itself" --------- Co-authored-by: Yeikel <email@yeikel.com> Co-authored-by: Guillaume Nodet <gnodet@gmail.com> # Conflicts: # .github/workflows/maven_build_itself.yml # maven-core/src/test/java/org/apache/maven/repository/TestRepositoryConnector.java
|
Backported. Note that the build is broken on JDK 21 due to an incompatibility in spotless. |
Closed
This was referenced Sep 11, 2023
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Sep 11, 2023
### What changes were proposed in this pull request? This PR aims to upgrade Maven to 3.9.4. ### Why are the changes needed? Apache Maven community starts to test Java 20 officially. Although this is only about a test coverage, we had better adopt it because 3.8.x is not tested officially by Apache Maven community. - https://issues.apache.org/jira/browse/MNG-7743 - apache/maven#1065 Here are the release notes. - https://maven.apache.org/docs/3.9.0/release-notes.html - https://maven.apache.org/docs/3.9.1/release-notes.html - https://maven.apache.org/docs/3.9.2/release-notes.html - https://maven.apache.org/docs/3.9.3/release-notes.html - https://maven.apache.org/docs/3.9.4/release-notes.html ### How was this patch tested? Pass the CIs with Java 21 EA build Closes #1612 from dongjoon-hyun/ORC-1502. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Sep 11, 2023
This PR aims to upgrade Maven to 3.9.4. Apache Maven community starts to test Java 20 officially. Although this is only about a test coverage, we had better adopt it because 3.8.x is not tested officially by Apache Maven community. - https://issues.apache.org/jira/browse/MNG-7743 - apache/maven#1065 Here are the release notes. - https://maven.apache.org/docs/3.9.0/release-notes.html - https://maven.apache.org/docs/3.9.1/release-notes.html - https://maven.apache.org/docs/3.9.2/release-notes.html - https://maven.apache.org/docs/3.9.3/release-notes.html - https://maven.apache.org/docs/3.9.4/release-notes.html Pass the CIs with Java 21 EA build Closes #1612 from dongjoon-hyun/ORC-1502. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 20345a2) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
cxzl25
pushed a commit
to cxzl25/orc
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This PR aims to upgrade Maven to 3.9.4. ### Why are the changes needed? Apache Maven community starts to test Java 20 officially. Although this is only about a test coverage, we had better adopt it because 3.8.x is not tested officially by Apache Maven community. - https://issues.apache.org/jira/browse/MNG-7743 - apache/maven#1065 Here are the release notes. - https://maven.apache.org/docs/3.9.0/release-notes.html - https://maven.apache.org/docs/3.9.1/release-notes.html - https://maven.apache.org/docs/3.9.2/release-notes.html - https://maven.apache.org/docs/3.9.3/release-notes.html - https://maven.apache.org/docs/3.9.4/release-notes.html ### How was this patch tested? Pass the CIs with Java 21 EA build Closes apache#1612 from dongjoon-hyun/ORC-1502. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.