Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move maven-compat to jsr330 #1149

Closed
wants to merge 1 commit into from
Closed

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jun 6, 2023

The goal of this PR is to completely get rid of old plexus annotations / plugins.
This requires moving maven-compat and the only remaining plexus components to JSR330.

@michael-o
Copy link
Member

Interesting..didn't we say we won't touch compat anymore?

@slachiewicz
Copy link
Member

Unfortunately we can't just drop this dependency

@michael-o
Copy link
Member

Unfortunately we can't just drop this dependency

So this is an intermediate step to ease the pain?

@gnodet
Copy link
Contributor Author

gnodet commented Jun 8, 2023

Unfortunately we can't just drop this dependency

So this is an intermediate step to ease the pain?

Yes, as I said, my goal was to clean the build, it just happens I had to get rid of old plexus plugin and I needed to move maven-compat to jsr330 for that. Quite a big work for a small goal, I agree.

That said, as the number of plugins using the org.apache.maven.repository.RepositorySystem is going down, we may be able to make maven-compat optional at some point. I'll work on a separate draft PR to see how/if this can be achieved.

@gnodet
Copy link
Contributor Author

gnodet commented Jun 12, 2023

Superseded by #1150

@gnodet gnodet closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants