Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7794][MNG-7809] Deprecate RepositorySystem and make maven-compat optional #1150

Merged
merged 7 commits into from
Jun 15, 2023

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Jun 8, 2023

  • Move maven-compat to jsr330
  • Remove more ties to RepositorySystem
  • Move more stuff to maven-compat
  • Move PluginManager and LocalRepositoryNotAccessibleException to maven-compat
  • Deprecate RepositorySystem MNG-7794

This PR effectively cut the runtime dependency from maven-core to maven-compat.
When all plugins are upgrade to their latest version (which will come when releasing
the parent POMs and upgrading to those), the maven distribution can build maven
after the removal of the maven-compat library from the distribution.

@gnodet
Copy link
Contributor Author

gnodet commented Jun 9, 2023

We could also move the ArtifactFactory and its implementation to maven-compat, but this would require getting rid of the MavenProject#createArtifacts method has been deprecated 9 years ago afaik.

The same is true for ReactorManager, EventDispatcher and EventMonitor as they are only used in a MavenSession's constructor and related getter.

@gnodet gnodet force-pushed the maven-compat-deprecate-more branch from 0d89b5b to aeb2386 Compare June 9, 2023 10:41
@gnodet gnodet changed the title Cut ties between maven-core and maven-compat [MNG-7794][MNG-7809] Deprecate RepositorySystem and make maven-compat optional Jun 12, 2023
@gnodet gnodet added this to the 4.0.0-alpha-6 milestone Jun 12, 2023
@gnodet gnodet merged commit 967d8fc into apache:master Jun 15, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants