test: World bank examples #12161
Merged
test: World bank examples #12161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12161 +/- ##
==========================================
- Coverage 66.79% 63.58% -3.21%
==========================================
Files 1014 486 -528
Lines 49524 29946 -19578
Branches 5077 0 -5077
==========================================
- Hits 33079 19042 -14037
+ Misses 16314 10904 -5410
+ Partials 131 0 -131
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kstrz
force-pushed
the
testing/world_bank_examples
branch
from
dadd9e2
to
70db575
Compare
kstrz
force-pushed
the
testing/world_bank_examples
branch
from
70db575
to
f149fea
Compare
willbarrett
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Looks good to me, would love for @dpgaspar to take a pass as well.
dpgaspar
reviewed
Jan 5, 2021
| "default_filters": "{}", | ||
| "color_scheme": None, | ||
| }, | ||
| "metadata": {"mock_key": "mock_value"}, |
There was a problem hiding this comment.
I think the old value was the side effect of some other tests. Now I set {"mock_key": "mock_value"} explicitly in the fixture.
kstrz
force-pushed
the
testing/world_bank_examples
branch
from
f149fea
to
c4d11cc
Compare
kstrz
force-pushed
the
testing/world_bank_examples
branch
2 times, most recently
from
bc7c313
to
f8e4297
Compare
kstrz
force-pushed
the
testing/world_bank_examples
branch
3 times, most recently
from
09b16bc
to
0d369fc
Compare
kstrz
force-pushed
the
testing/world_bank_examples
branch
from
0d369fc
to
623857c
Compare
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Jan 14, 2021
* add world bank data fixture * fix fixture cleanup, add fixture to dashboard_tests * apply world bank fixtures, fix tests * fix fixture typo, dashboard ids * fix export dashboard metadata * fix test_export_dashboard_command_key_order * fix export dash tests, not add row when no orphans * debug timeout * fixes after merge * fix lint * run pre-commit * comment test for debug * fix save.test.js Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>
villebro
pushed a commit
that referenced
this pull request
Jan 25, 2021
* add world bank data fixture * fix fixture cleanup, add fixture to dashboard_tests * apply world bank fixtures, fix tests * fix fixture typo, dashboard ids * fix export dashboard metadata * fix test_export_dashboard_command_key_order * fix export dash tests, not add row when no orphans * debug timeout * fixes after merge * fix lint * run pre-commit * comment test for debug * fix save.test.js Co-authored-by: Karol Kostrzewa <karol.kostrzewa@polidea.com>
mistercrunch
added
🍒 1.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replace World Bank data example with data loaded by fixture for tests. The aim was to get rid of an external dependency.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
All tests should be green.
ADDITIONAL INFORMATION