Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Elestio as deployment option #25775

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

kaiwalyakoparkar
Copy link
Contributor

closes #25774

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley
Copy link
Member

Thanks @kaiwalyakoparkar for the change. Unfortunately only official Apache deployment processes can be listed, i.e., non-commercial. You're welcome to add a link here.

@rusackas
Copy link
Member

Sorry we didn't see this sooner! I'll merge it as soon as it passes CI. I'll close/open this to make CI run again.

@rusackas rusackas closed this Aug 22, 2024
@rusackas rusackas reopened this Aug 22, 2024
@rusackas rusackas merged commit 5906890 into apache:master Aug 22, 2024
61 checks passed
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.01%. Comparing base (ed14f36) to head (cd54acf).
Report is 1653 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #25775   +/-   ##
=======================================
  Coverage   69.01%   69.01%           
=======================================
  Files        1934     1934           
  Lines       75609    75609           
  Branches     8415     8415           
=======================================
  Hits        52184    52184           
  Misses      21264    21264           
  Partials     2161     2161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIP] Adding Elestio as Deployment option
3 participants