Update supported go versions to 1.20 and 1.21 #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
commented
Jun 23, 2023
| @@ -163,7 +163,7 @@ Thrift's core protocol is TBinary, supported by all languages except for JavaScr | |||
| <td align=left><a href="https://github.com/apache/thrift/blob/master/lib/go/README.md">Go</a></td> | |||
| <!-- Since -----------------><td>0.7.0</td> | |||
| <!-- Build Systems ---------><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td> | |||
| <!-- Language Levels -------><td>1.19.5</td><td>1.20</td> | |||
| <!-- Language Levels -------><td>1.20</td><td>1.21</td> | |||
There was a problem hiding this comment.
note that I removed patch version here because now with github actions we are always using the latest patch version under the minor version in tests.
jimexist
approved these changes
Jul 5, 2023
|
@dcelasun now 1.21 is released, I fixed the TODO in workflow file. |
|
The crosstest failures between java/kotlin and go are due to https://issues.apache.org/jira/browse/THRIFT-5653. merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the PR ready to be merged once go 1.21 releases.