Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported go versions to 1.20 and 1.21 #2821

Merged
merged 1 commit into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ jobs:
strategy:
matrix:
go:
- '1.19'
- '1.20'
- '1.21'
fail-fast: false
steps:
- uses: actions/checkout@v3
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
run: make -C test/go precross

- name: Upload go precross artifacts
if: matrix.go == '1.20'
if: matrix.go == '1.21'
uses: actions/upload-artifact@v3
with:
name: go-precross
Expand Down
2 changes: 1 addition & 1 deletion LANGUAGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ Thrift's core protocol is TBinary, supported by all languages except for JavaScr
<td align=left><a href="https://github.com/apache/thrift/blob/master/lib/go/README.md">Go</a></td>
<!-- Since -----------------><td>0.7.0</td>
<!-- Build Systems ---------><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td>
<!-- Language Levels -------><td>1.19.5</td><td>1.20</td>
<!-- Language Levels -------><td>1.20</td><td>1.21</td>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that I removed patch version here because now with github actions we are always using the latest patch version under the minor version in tests.

<!-- Field types -----------><td><img src="/doc/images/cred.png" alt=""/></td>
<!-- Low-Level Transports --><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cred.png" alt=""/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td>
<!-- Transport Wrappers ----><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td><td><img src="/doc/images/cgrn.png" alt="Yes"/></td>
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module github.com/apache/thrift

go 1.19
go 1.20
2 changes: 1 addition & 1 deletion lib/go/test/fuzz/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/apache/thrift/lib/go/test/fuzz

go 1.19
go 1.20

replace github.com/apache/thrift => ../../../../

Expand Down
2 changes: 1 addition & 1 deletion lib/go/test/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/apache/thrift/lib/go/test

go 1.19
go 1.20

require (
github.com/apache/thrift v0.0.0-00010101000000-000000000000
Expand Down
2 changes: 1 addition & 1 deletion test/go/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/apache/thrift/test/go

go 1.19
go 1.20

require (
github.com/apache/thrift v0.0.0-00010101000000-000000000000
Expand Down
Loading