Skip to content

Commit

Permalink
Specify version for @types/express-serve-static-core
Browse files Browse the repository at this point in the history
This is another attempt to solve the problem of #4493.

The problem is that the new version of `@types/express` we use in this release
actually does require a newer version of `@types/express-serve-static-core`, but
it only uses `*` as a version constraint. So while from-scratch installs of
`apollo-server-express` will pull in the newest version of
`@types/express-serve-static-core`, upgrades will only bother to upgrade
`@types/express` and TypeScript will fail.
  • Loading branch information
glasser committed Sep 21, 2020
1 parent 9e5cd28 commit c67e8ec
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/apollo-server-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"@types/body-parser": "1.19.0",
"@types/cors": "2.8.7",
"@types/express": "4.17.7",
"@types/express-serve-static-core": "4.17.9",
"accepts": "^1.3.5",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-types": "file:../apollo-server-types",
Expand Down

0 comments on commit c67e8ec

Please sign in to comment.