chore(deps): specify versions for @types/express and friends
#4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 91b8839 @abernix updated package-lock for `@types/express` (something I had also noted happened on a branch I was working on). Soon after, in #4327, that line got dropped from package-lock.json. I'm guessing this caused the issue I started seeing soon afterwards, where I'd get lots of compile errors relating to `@types/express` and other DefinitelyTyped packages it depends on. Turns out the dependencies from `@types/express` are unversioned, but the latest versions of that type package depends on the latest versions of a bunch of other type packages. This commit seems to fix things for me.
- We don't directly depend on `@types/express-serve-static-core`, so I don't quite understand the addition of those. I seem to not have the flapping of deps without adding it! - We shouldn't need to package the `@types/qs` (or the aforementioned pkg) into the `apollo-server-express` package's non-dev deps because none of those types are exported from our emitted `d.ts` files. Those dependencies should be brought by the corresponding packages if there are transitive dep needs.
|
Hmm, it does suck that the dependencies from Thanks for explaining that the reason for |
|
FWIW when building an app depending on tarballs from #4453, I did run into errors due to the version of |
glasser
added a commit
that referenced
this pull request
Sep 21, 2020
This is another attempt to solve the problem of #4493. The problem is that the new version of `@types/express` we use in this release actually does require a newer version of `@types/express-serve-static-core`, but it only uses `*` as a version constraint. So while from-scratch installs of `apollo-server-express` will pull in the newest version of `@types/express-serve-static-core`, upgrades will only bother to upgrade `@types/express` and TypeScript will fail.
abernix
added a commit
that referenced
this pull request
Mar 7, 2021
...with a little extra help from @abernix because these types seem like they're acting up again. This time, I've found another issue on DefinitelyTyped that seems like it's prescribing a solution that was occurring in this particular attempt at updating the types, resulting in the error message of: Namespace 'serveStatic' has no exported member 'RequestHandlerConstructor' The (attempted, but seemingly working) fix was: npm update @types/express-serve-static-core --depth 2 npm update @types/serve-static --depth 2 Ref: DefinitelyTyped/DefinitelyTyped#49595 But also, in reverse chronological order at attempted resolution: Ref: 6e86f67 Ref: #4493 Ref: c67e8ec Cc: @glasser
abernix
added a commit
that referenced
this pull request
Mar 7, 2021
...with a little extra help from @abernix because these types seem like they're acting up again. This time, I've found another issue on DefinitelyTyped that seems like it's prescribing a solution that was occurring in this particular attempt at updating the types, resulting in the error message of: Namespace 'serveStatic' has no exported member 'RequestHandlerConstructor' The (attempted, but seemingly working) fix was: npm update @types/express-serve-static-core --depth 2 npm update @types/serve-static --depth 2 Ref: DefinitelyTyped/DefinitelyTyped#49595 But also, in reverse chronological order at attempted resolution: Ref: 6e86f67 Ref: #4493 Ref: c67e8ec Cc: @glasser Co-authored-by: Jesse Rosenberger <git@jro.cc>
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 91b8839 @abernix updated package-lock for
@types/express(something I hadalso noted happened on a branch I was working on). Soon after, in #4327, that
line got dropped from package-lock.json.
I'm guessing this caused the issue I started seeing soon afterwards, where I'd
get lots of compile errors relating to
@types/expressand otherDefinitelyTyped packages it depends on. Turns out the dependencies from
@types/expressare unversioned, but the latest versions of that type packagedepends on the latest versions of a bunch of other type packages.
This commit seems to fix things for me.