Skip to content

Commit

Permalink
chore(deps): update dependency @types/express to v4.17.11 (#4850)
Browse files Browse the repository at this point in the history
...with a little extra help from @abernix because these types seem like
they're acting up again.  This time, I've found another issue on
DefinitelyTyped that seems like it's prescribing a solution that was
occurring in this particular attempt at updating the types, resulting in the
error message of:

  Namespace 'serveStatic' has no exported member 'RequestHandlerConstructor'

The (attempted, but seemingly working) fix was:

    npm update @types/express-serve-static-core --depth 2
    npm update @types/serve-static --depth 2

Ref: DefinitelyTyped/DefinitelyTyped#49595

But also, in reverse chronological order at attempted resolution:

Ref: 6e86f67
Ref: #4493
Ref: c67e8ec
Cc: @glasser

Co-authored-by: Jesse Rosenberger <git@jro.cc>
  • Loading branch information
renovate[bot] and abernix committed Mar 7, 2021
1 parent a76760a commit 9e5ae76
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 29 deletions.
56 changes: 29 additions & 27 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"@types/bunyan": "1.8.6",
"@types/connect": "3.4.34",
"@types/cors": "2.8.8",
"@types/express": "4.17.7",
"@types/express": "4.17.11",
"@types/fast-json-stable-stringify": "2.0.0",
"@types/hapi": "17.8.10",
"@types/ioredis": "4.22.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/apollo-server-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@types/accepts": "^1.3.5",
"@types/body-parser": "1.19.0",
"@types/cors": "2.8.8",
"@types/express": "4.17.7",
"@types/express": "4.17.11",
"@types/express-serve-static-core": "4.17.18",
"accepts": "^1.3.5",
"apollo-server-core": "file:../apollo-server-core",
Expand Down

0 comments on commit 9e5ae76

Please sign in to comment.