Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expressMiddleware to express4 deep import #6612

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

glasser
Copy link
Member

@glasser glasser commented Jun 24, 2022

While expressMiddleware has no runtime dependencies, it does rely on the
specific API of Express 4. One of the nice things about Express is that
its development had slowed and it was a very stable target, but all good
things must come to an end: Express 5 may be coming soon
expressjs/express#4920

(I kid: the changes in Express 5, like support for proper error handling
with async functions, look great.)

So let's preemptively put this under /express4 so that if the Express
5 middleware needs to be a bit different (if nothing else, the req/res
types in the context function may vary) that we'll have an obvious place
to put it.

Fixes #6587.

While expressMiddleware has no runtime dependencies, it does rely on the
specific API of Express 4. One of the nice things about Express is that
its development had slowed and it was a very stable target, but all good
things must come to an end: Express 5 may be coming soon
expressjs/express#4920

(I kid: the changes in Express 5, like support for proper error handling
with async functions, look great.)

So let's preemptively put this under `/express4` so that if the Express
5 middleware needs to be a bit different (if nothing else, the req/res
types in the context function may vary) that we'll have an obvious place
to put it.

Fixes #6587.
@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit cf1a2d7
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/62b517e21d3a7100094ae0c2
😎 Deploy Preview https://deploy-preview-6612--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf1a2d7:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser glasser merged commit bbe883f into version-4 Jun 24, 2022
@glasser glasser deleted the glasser/express-deep-import branch June 24, 2022 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants