Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expressMiddleware to express4 deep import #6612

Merged
merged 1 commit into from
Jun 24, 2022

Commits on Jun 24, 2022

  1. Move expressMiddleware to express4 deep import

    While expressMiddleware has no runtime dependencies, it does rely on the
    specific API of Express 4. One of the nice things about Express is that
    its development had slowed and it was a very stable target, but all good
    things must come to an end: Express 5 may be coming soon
    expressjs/express#4920
    
    (I kid: the changes in Express 5, like support for proper error handling
    with async functions, look great.)
    
    So let's preemptively put this under `/express4` so that if the Express
    5 middleware needs to be a bit different (if nothing else, the req/res
    types in the context function may vary) that we'll have an obvious place
    to put it.
    
    Fixes #6587.
    glasser committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    cf1a2d7 View commit details
    Browse the repository at this point in the history