Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the full operation and schema to generate query key hashes #5028

Merged
merged 8 commits into from
Apr 26, 2024

Conversation

o0Ignition0o
Copy link
Contributor

No description provided.

@router-perf
Copy link

router-perf bot commented Apr 26, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

let query_two = "query { a: test(arg: 1) b: test(arg: 3) }";

// this test won't pass until we land a fix for it
// assert!(hash(schema, query_one).doesnt_match(&hash(schema, query_two)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to put this back in 🕺

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — I clarified the comment above (which confused me too)

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the reviews before now are fair, let's hold on final review until we are 🎀 fit and finish is done — including reinstating the test noted above.

@abernix abernix merged commit b2edc75 into 1.45.1 Apr 26, 2024
6 of 7 checks passed
@abernix abernix deleted the igni/put_full_operation_in_cache_key branch April 26, 2024 19:31
xuorig pushed a commit to Netflix-Skunkworks/router that referenced this pull request Apr 26, 2024
…ographql#5028)

Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: David Glasser <glasser@davidglasser.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants