-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use the full operation and schema to generate query key hashes #5028
Conversation
CI performance tests
|
let query_two = "query { a: test(arg: 1) b: test(arg: 3) }"; | ||
|
||
// this test won't pass until we land a fix for it | ||
// assert!(hash(schema, query_one).doesnt_match(&hash(schema, query_two))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to put this back in 🕺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks — I clarified the comment above (which confused me too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the reviews before now are fair, let's hold on final review until we are 🎀 fit and finish is done — including reinstating the test noted above.
…ographql#5028) Co-authored-by: Jesse Rosenberger <git@jro.cc> Co-authored-by: David Glasser <glasser@davidglasser.net>
No description provided.