-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile dev after merge to main for v1.45.1 #5037
Conversation
Add indentation to indicate labels are associated with the above metric. Thanks! Co-authored-by: Geoffroy Couprie <apollo@geoffroycouprie.com>
…#4848) replace trait implementation for supergraph_service from router::BoxService to supergraph::BoxService Co-authored-by: Geoffroy Couprie <apollo@geoffroycouprie.com>
@Geal, please consider creating a changeset entry in |
CI performance tests
|
this.schema.supergraph_schema(), | ||
&this.schema.raw_sdl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: here's an additional fix to the query hash I just found: the hashing mechanism has to be done on the supergraph schema, not the API schema. If needed I can split that change in a separate PR, that we would merge immediately after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema.supergraph_schema(), | ||
&schema.raw_sdl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as the other note, this can be moved to a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we land this and track the follow-up somewhere else?
we can land this. There was one additional fix I had to do to make tests pass: 5f86cd4 |
50eb674 is due to the typed conditions PR being merged in dev while 1.45.1 was worked on, so the schema aware hashes for subgraph queries change for those tests because this PR changes the algorithm with the fixes from 1.45.1 |
Follow-up to the v1.45.1 being officially released, bringing version bumps and changelog updates into the dev branch.
Separating this from #5036 to solve the conflicts between main and dev without making an additional commit to main
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩