Do not loose downloaded files in mirror update #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sliverc
changed the title
|
Thanks, I have more complete fix in the works, I'll push it soon (covers also aborted downloads). |
|
Closing this PR in favor of #683 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651
Description of the Change
If some files during mirror update fail to download all downloaded files would be lost and redownloaded again in a second mirror update call.
This fix import files which have successfully been downloaded but mirror update is still marked as failed. What this doesn't fix is when aptly process is canceled. This I guess will be addressed with fix for #545
Checklist
AUTHORS