Use Go context to abort gracefully mirror updates #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two fixes here: 1. Abort package download immediately as ^C is pressed. 2. Import all the already downloaded files into package pool, so that next time mirror is updated, aptly won't download them once again.
sliverc
reviewed
Nov 30, 2017
context/context.go
Outdated
| @@ -30,6 +32,8 @@ import ( | |||
| type AptlyContext struct { | |||
| sync.Mutex | |||
|
|
|||
| ctx gocontext.Context | |||
There was a problem hiding this comment.
I was just browsing through this change. Thanks for working on this issue.
One question I have is though wouldn't it be better and more readable when go context is an embedded type of Aptly context (like sync.Mutex)? This way aptly and go context can be used interchangeably.
There was a problem hiding this comment.
Interesting idea, I never thought about it to be honest. I'll try it, thanks!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two fixes here:
so that next time mirror is updated, aptly won't download them
once again.
Fixes #545
Requirements
Checklist
AUTHORS