Allow a custom Suite when publishing #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is PR #831 rebased against |
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 63.81% 63.79% -0.02%
==========================================
Files 54 54
Lines 6665 6673 +8
==========================================
+ Hits 4253 4257 +4
- Misses 1887 1890 +3
- Partials 525 526 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 63.81% 63.79% -0.02%
==========================================
Files 54 54
Lines 6665 6673 +8
==========================================
+ Hits 4253 4257 +4
- Misses 1887 1890 +3
- Partials 525 526 +1
Continue to review full report at Codecov.
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
A
-suiteparameter is added for publishing. If it's not provided, thendistributionis used (current default).Why this change is important?
Starting from Ubuntu bionic,
aptchecks that theLabel,OriginandSuiteof a repo remains the same. If they change, it requires manual confirmation from the user. Hence, administrators migrating toaptlyneed to have the flexibility to set a custom Suite field.This change is also important because distributions use the Suite for tagging the release in different ways. For example, Debian uses the suites for tagging
stable,oldstable,oldoldstable, etc.Checklist
AUTHORSAbout tests
At the moment, not all the tests are passing. I think this might be related to the recent archival of wheezy. I added tests related to this change, but didn't fix the ones that were already broken.