Enable the ability to set a custom Codename when publishing #892
Conversation
While testing out Aptly, the `apt-get` client complains with the following error, since the `codename` was switched from the InRelease files that are baked out by Aptly: ``` E: Repository 'http://debianrepo.example.com/bionic testing InRelease' changed its 'Codename' value from '' to 'testing' ```
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
==========================================
- Coverage 63.79% 63.78% -0.02%
==========================================
Files 54 54
Lines 6674 6682 +8
==========================================
+ Hits 4258 4262 +4
- Misses 1890 1893 +3
- Partials 526 527 +1
Continue to review full report at Codecov.
|
|
Hello @smira, is it possible to get this reviewed? Thanks for your time. |
Ubuntu 18.04 performs strict checking of the Codename and Label when performing an apt-get update. The snapshots published by aptly do not set these parameters in a way that apt-get likes. This change explicitly sets the codename and label based on the values from the upstream repo being mirrored. Note: this relies on a currently unmerged pull request/ aptly-dev/aptly#892 Change-Id: I011862dcf9efbb8b1f9757c65f3d58da49a496d7
* Update openstack-helm-images from branch 'master'
- mini-mirror: Preserve codename and label
Ubuntu 18.04 performs strict checking of the Codename and Label when
performing an apt-get update. The snapshots published by aptly do not
set these parameters in a way that apt-get likes.
This change explicitly sets the codename and label based on the values
from the upstream repo being mirrored.
Note: this relies on a currently unmerged pull request/
aptly-dev/aptly#892
Change-Id: I011862dcf9efbb8b1f9757c65f3d58da49a496d7
|
I wanted to bump this - we are having the same issue. This pull request resolves it; is it possible to get this merged @smira ? |
There was a problem hiding this comment.
Looks good to me!
@smstone if you are still interested in this change, would you mind rebasing and have a look at why the tests are failing now that we moved the new github actions pipeline 🎉
|
I will close this as there seems to be a lack of interest for this change, feel free to leave a comment if you want this reopened |
Description of the Change
This change will allow users to set a custom
Codenamein the release files when publishing.This PR is inspired/guided by #874
Why this change is important?
While testing out Aptly, our test
apt-getclients were exiting with non-zero status sinceCodenamewas changed in the release files that are baked out by Aptly:I attempted to update system tests / man pages, apologies if something was missed. I can also split these out into separate commits, if that is preferable.
Checklist
AUTHORS