FreeBSD: replace getnameinfo with inet_ntop #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correabuscar
commented
Nov 6, 2022
correabuscar
force-pushed
the
freebsd_replace__getnameinfo__with__inet_ntop
branch
from
5fe2891
to
e938ccb
Compare
correabuscar
commented
Nov 6, 2022
also make IPv6 work.
correabuscar
force-pushed
the
freebsd_replace__getnameinfo__with__inet_ntop
branch
from
e938ccb
to
12def52
Compare
aristocratos
approved these changes
Nov 6, 2022
Yeah, there is currently no method employed to get the MAC address in freebsd (or macos I think). In linux it's collected from |
correabuscar
added a commit
to correabuscar/btop
that referenced
this pull request
Nov 6, 2022
this is like PR aristocratos#462 for FreeBSD, and like PR aristocratos#458 for Linux.
correabuscar
added a commit
to correabuscar/btop
that referenced
this pull request
Nov 6, 2022
this is like PR aristocratos#462 for FreeBSD, and like PR aristocratos#458 for Linux.
correabuscar
added a commit
to correabuscar/btop
that referenced
this pull request
Nov 6, 2022
this is like PR aristocratos#462 for FreeBSD, and like PR aristocratos#458 for Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also make IPv6 work (previously it was commented out)
(re)tested it to work in freebsd 13.1 in virtualbox, not just to compile.
Note that, unlike in Linux, if all IPv4 and IPv6 IPs are missing, then the interface MAC isn't shown in their place (but this is a different issue)