osx: replace getnameinfo with inet_ntop #464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is like PR #462 for FreeBSD,
and like PR #458 for Linux.
I can't test the build and run for these, as I've been unable to get macOS in virtualbox (tried 4 iso`s). But I'll look in github actions for the build, and just hope the runs work fine on bare metal.
outdated info
Unsure about those
#include
`s: is#include <arpa/inet.h>
the same as#include <sys/arpa/inet.h>
?I've got them from:
src: https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/inet_ntop.3.html
PS: Thank you for this learning experience btw :) (with all the PRs, not just this one)