This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Update Emission to 1.50, using React Native 0.54.4 #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
reviewed
Apr 17, 2018
| mkdir ~/.cocoapods/repos/artsy/yoga/$(YOGAVERSION) | ||
| mkdir ~/.cocoapods/repos/artsy/Folly/$(FOLLYVERSION) | ||
| mkdir ~/.cocoapods/repos/artsy/DoubleConversion/$(DOUBLECONVERSIONVERSION) | ||
| mkdir ~/.cocoapods/repos/artsy/glog/$(GLOGVERSION) |
There was a problem hiding this comment.
This code was wrong, we didn't need to ship them to our specs repo because they existed inside the public specs repo
orta
reviewed
Apr 17, 2018
| ship_yoga: | ||
| # curl $(YOGA_MASTER_PODSPEC_URL) > ./externals/yoga/yoga.podspec | ||
| INSTALL_YOGA_WITHOUT_PATH_OPTION="true" pod ipc spec ./externals/yoga/yoga.podspec > ./externals/yoga/yoga.podspec.json | ||
| # rm -f ./externals/yoga/yoga.podspec |
There was a problem hiding this comment.
The 0.54.2 version of RN does not include facebook/react-native#18492 - so, we use the master version and run that through the pod IPC command to generate JSON to put in this repo
|
Ok, then this is good to go. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches @orta's PR on Eigen. As soon as we have the Eigen release out containing AR and Buy Now fixes, we can point Eigen to this cut of Emission.
There are some yoga changes here (due to
Yogabeing renamed toyoga). We can't have both in the same spec repo, so we have a backwards compatibleYogapodspec we're keeping around.🎉