Updates Yoga to handle being in a Xcode framework project #18492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This PR deprecates #17764 |
|
This fails on Android, which the PR doesn't touch - so should probably be considered green 👍 |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Mar 21, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
1 task
|
Thank you thank you thank you @orta ! |
hamaron
pushed a commit
to hamaron/react-native
that referenced
this pull request
Apr 9, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
campsafari
pushed a commit
to exozet/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
LukeDurrant
pushed a commit
to LukeDurrant/react-native
that referenced
this pull request
Apr 11, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
bunnyc1986
pushed a commit
to bunnyc1986/react-native
that referenced
this pull request
May 11, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
vovkasm
pushed a commit
to vovkasm/react-native
that referenced
this pull request
Jun 5, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Updates the Yoga Podspec to work with Cocoa frameworks. Replicated a2's work over on Yoga facebook/yoga#726 (Which should also get merged too please ❤️ ) Set it manually in my own project and tested 👍 Only facebook/yoga#726 [IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks. Closes facebook#18492 Differential Revision: D7355907 Pulled By: hramos fbshipit-source-id: 6986d2bc560a23bb7f0f20b80e88bb440079891a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Yoga Podspec to work with Cocoa frameworks. Replicated @a2's work over on Yoga facebook/yoga#726
(Which should also get merged too please ❤️ )
Test Plan
Set it manually in my own project and tested 👍
Related PRs
Only facebook/yoga#726
Release Notes
[IOS] [BUGFIX] [Yoga] - Fixes to yoga.podspec when integrating into an iOS app using Cocoa frameworks.