Change public headers #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morozkin, we must find a way to support both 🤔 |
|
@morozkin I'm not sure this would help, but I've seen this new PR on yoga: facebook/yoga#777 |
Merge layoutBox/FlexLayout master branch into update_public_headers
|
I will close this branch @morozkin since there is no action since may 9th. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lucdion !
I faced with the problem while trying to integrate your tool into my project via Cocoapods as a static framework. The problem is
YGLayout+Privateheader which is imported because of its existence in modulemap file. This header indirectly importsYoga-internalwhich includes C++ STL headers. And here the problem, compiler can't find these headers and I get compilation error.The similar issue arrised for users of ReactNative which also uses yoga. For ReactNative the problem was that all headers were public since there wasn't
public_header_filesdefined in podspec. You can have a look at the merged PR with the solution.For successfully building FlexLayout as static framework we have to remove
YGLayout+Private.hfrom the master header and exclude it from the list ofpublic_header_filessince there is no reason for doing this.But there is another problem, while my solution works perfectly for static frameworks it doesn't work for dynamic ones and you can see the same error in travis logs.