Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Frame.is_xyz public, so we can build up custom filters easiler #49

Merged
merged 2 commits into from
Oct 22, 2023
Merged

make Frame.is_xyz public, so we can build up custom filters easiler #49

merged 2 commits into from
Oct 22, 2023

Conversation

WindSoilder
Copy link
Contributor

Closes: #48

As a result, we can build up custom filters from Frame.is_xyz methods

athre0z
athre0z reviewed Oct 22, 2023
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
athre0z
athre0z approved these changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now -- thanks for the PR!

@athre0z athre0z merged commit 359c1ad into athre0z:master Oct 22, 2023
4 checks passed
@athre0z
Copy link
Owner

athre0z commented Oct 22, 2023

I've also cut a new release (v0.6.1) so that you can actually use these without having to hard-code a git revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athre0z athre0z athre0z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider making Frame::is_dependency_code public?
2 participants
@WindSoilder @athre0z