Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Frame.is_xyz public, so we can build up custom filters easiler #49

Merged
merged 2 commits into from
Oct 22, 2023
Merged

make Frame.is_xyz public, so we can build up custom filters easiler #49

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d04fcc8
make Frame.is_xyz public, so we can build up custom filters easiler
WindSoilder Oct 21, 2023
ebaa08d
don't expose too much
WindSoilder Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl Frame {
///
/// If it fails to detect some patterns in your code base, feel free to drop
/// an issue / a pull request!
fn is_dependency_code(&self) -> bool {
pub fn is_dependency_code(&self) -> bool {
const SYM_PREFIXES: &[&str] = &[
"std::",
"core::",
Expand Down Expand Up @@ -218,7 +218,7 @@ impl Frame {
/// Post panic frames are frames of a functions called after the actual panic
/// is already in progress and don't contain any useful information for a
/// reader of the backtrace.
fn is_post_panic_code(&self) -> bool {
pub fn is_post_panic_code(&self) -> bool {
const SYM_PREFIXES: &[&str] = &[
"_rust_begin_unwind",
"rust_begin_unwind",
Expand All @@ -239,7 +239,7 @@ impl Frame {

/// Heuristically determine whether a frame is likely to be part of language
/// runtime.
fn is_runtime_init_code(&self) -> bool {
pub fn is_runtime_init_code(&self) -> bool {
const SYM_PREFIXES: &[&str] = &[
"std::rt::lang_start::",
"test::run_test::run_test_inner::",
Expand All @@ -263,7 +263,11 @@ impl Frame {
false
}

fn print_source_if_avail(&self, mut out: impl WriteColor, s: &BacktracePrinter) -> IOResult {
pub fn print_source_if_avail(
WindSoilder marked this conversation as resolved.
Show resolved Hide resolved
&self,
mut out: impl WriteColor,
s: &BacktracePrinter,
) -> IOResult {
let (lineno, filename) = match (self.lineno, self.filename.as_ref()) {
(Some(a), Some(b)) => (a, b),
// Without a line number and file name, we can't sensibly proceed.
Expand Down