Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticache controller - make usage of SecurityGroup Ref. #1860

Closed
gecube opened this issue Jul 28, 2023 · 3 comments · Fixed by aws-controllers-k8s/elasticache-controller#123
Closed

Elasticache controller - make usage of SecurityGroup Ref. #1860

gecube opened this issue Jul 28, 2023 · 3 comments · Fixed by aws-controllers-k8s/elasticache-controller#123
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. service/elasticache Indicates issues or PRs that are related to elasticache-controller.

Comments

@gecube
Copy link

gecube commented Jul 28, 2023 •
edited
Loading

Good day!

I am extensively using Elasticache controller. Unfortunately, right now I need to create SG BEFORE creating the redis instance and getting the precise ID of security group by console means:

apiVersion: elasticache.services.k8s.aws/v1alpha1
kind: ReplicationGroup
metadata:
  name: redisapp
  namespace: infra-production
spec:
  cacheSubnetGroupName: cache-subnet
  transitEncryptionEnabled: false
  engine: redis
  description: redisapp
  replicationGroupID: redisapp
  cacheNodeType: cache.m6g.2xlarge
  securityGroupIDs:
    - sg-00f317b1a0953075c

I am kindly asking to add securityGroups field in ec2.services.k8s.aws/v1alpha1 Instance or like vpcSecurityGroupRefs in DBInstance from rds.services.k8s.aws/v1alpha. This field will contain references to sg names instead of precise ids.
It will allow to remove some unnecessary manual steps.
@jljaco jljaco added kind/enhancement Categorizes issue or PR as related to existing feature enhancements. service/elasticache Indicates issues or PRs that are related to elasticache-controller. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 15, 2023
jose-fully-ported pushed a commit to jose-fully-ported/elasticache-controller that referenced this issue Nov 22, 2023
@josegonzalez
feat: add refs support for various fields
05b1479 
The following fields have had refs support added:

- CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
- CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
- CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
- SecurityGroupIDs: ec2.SecurityGroup.Status.ID

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860
jose-fully-ported pushed a commit to jose-fully-ported/elasticache-controller that referenced this issue Nov 22, 2023
@josegonzalez
feat: add refs support for various fields
67b7543 
The following fields have had refs support added:

- CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
- ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
- ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
- ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860
@jose-fully-ported jose-fully-ported mentioned this issue Nov 22, 2023
Merged
jose-fully-ported added a commit to jose-fully-ported/elasticache-controller that referenced this issue Nov 22, 2023
@jose-fully-ported
feat: add refs support for various fields
25e5d0b 
The following fields have had refs support added:

- CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
- ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
- ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
- ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860
ack-prow bot pushed a commit to aws-controllers-k8s/elasticache-controller that referenced this issue Nov 22, 2023
@jose-fully-ported
feat: add refs support for various fields (#123)
4aa7ba4 
## Issue #, if available:

Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860

## Description of changes:

The following fields have had refs support added:

- CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID
- ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName
- ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName
- ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@a-hilaly a-hilaly reopened this Nov 22, 2023
@a-hilaly
Copy link
Member

Expecting an elasticache-controller release today

@a-hilaly
Copy link
Member

Supported in elasticache-controller v0.0.28 - thank you @jose-fully-ported for this addition!
/close

@ack-prow ack-prow bot closed this as completed Nov 22, 2023
@ack-prow ACK Prow
Copy link

ack-prow bot commented Nov 22, 2023

@a-hilaly: Closing this issue.

In response to this:

Supported in elasticache-controller v0.0.28 - thank you @jose-fully-ported for this addition!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Categorizes issue or PR as related to existing feature enhancements. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. service/elasticache Indicates issues or PRs that are related to elasticache-controller.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add refs support for various fields jose-fully-ported/elasticache-controller
3 participants
@gecube @a-hilaly @jljaco