-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add refs support for various fields #123
feat: add refs support for various fields #123
Conversation
Hi @jose-fully-ported. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The following fields have had refs support added: - CacheSubnetGroup.SubnetIDs: ec2.Subnet.Status.SubnetID - ReplicationGroup.CacheParameterGroupName: CacheParameterGroup.Spec.CacheParameterGroupName - ReplicationGroup.CacheSubnetGroupName: CacheSubnetGroup.Spec.CacheSubnetGroupName - ReplicationGroup.SecurityGroupIDs: ec2.SecurityGroup.Status.ID Closes aws-controllers-k8s/community#1513 Closes aws-controllers-k8s/community#1860
67b7543
to
25e5d0b
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution @jose-fully-ported ! 👍
Ideally we want to add e2e tests for references that are managed by the same controller (elasticache-controller). But this is non-blocking since the controller is not GA. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jose-fully-ported The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Closes aws-controllers-k8s/community#1513
Closes aws-controllers-k8s/community#1860
Description of changes:
The following fields have had refs support added:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.