Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neptune: specify port for the cluster #31074

Closed
1 of 2 tasks
badmintoncryer opened this issue Aug 10, 2024 · 3 comments · Fixed by #31137
Closed
1 of 2 tasks

neptune: specify port for the cluster #31074

badmintoncryer opened this issue Aug 10, 2024 · 3 comments · Fixed by #31137
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

Specify port number of the Neptune cluster.

Use Case

We can configure the port number of Neptune cluster but CDK L2 construct cannot configure this.

Proposed Solution

Add port property to DatabaseClusterProps and set DBPort to the port value.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-neptune-dbcluster.html#cfn-neptune-dbcluster-dbport

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.150.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 10, 2024
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Aug 10, 2024
@github-actions github-actions bot mentioned this issue Aug 12, 2024
Closed
@ashishdhingra ashishdhingra self-assigned this Aug 12, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 12, 2024
@ashishdhingra
Copy link
Contributor

Looking at DatabaseClusterProps, there appears to be no property that maps to DBPort. However, per AWS::Neptune::DBCluster appears to be supported property (there is also Port property, however, there is a note that This property will soon be deprecated. Please update existing templates to use the new DBPort property that has the same functionality.).

@badmintoncryer Thanks for submitting the feature request. Kindly note that aws-neptune-alpha is an experimental L2 construct as of now, so we encourage community to submit updates to this construct package. Feel free to submit PR that could be reviewed by the team.

Thanks,
Ashish

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Aug 12, 2024
@ashishdhingra ashishdhingra removed their assignment Aug 12, 2024
@badmintoncryer badmintoncryer mentioned this issue Aug 18, 2024
Merged
1 task
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Open
@mergify mergify bot closed this as completed in #31137 Sep 4, 2024
@mergify mergify bot closed this as completed in 130b62b Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024
pahud pushed a commit to pahud/aws-cdk that referenced this issue Sep 9, 2024
@badmintoncryer @pahud
feat(neptune-alpha): specify port for the cluster (aws#31137)
29d3c17 
### Issue # (if applicable)

Closes aws#31074.

### Reason for this change

Cloudformation supports for setting port number for the Neptune cluster but AWS CDK cannot do this.

### Description of changes

Add `port` prop to `DatabaseClusterProps`.

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
xazhao pushed a commit to xazhao/aws-cdk that referenced this issue Sep 12, 2024
@badmintoncryer @xazhao
feat(neptune-alpha): specify port for the cluster (aws#31137)
b1a11d0 
### Issue # (if applicable)

Closes aws#31074.

### Reason for this change

Cloudformation supports for setting port number for the Neptune cluster but AWS CDK cannot do this.

### Description of changes

Add `port` prop to `DatabaseClusterProps`.

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
GavinZZ pushed a commit that referenced this issue Sep 12, 2024
@badmintoncryer @GavinZZ
feat(neptune-alpha): specify port for the cluster (#31137)
7011cb1 
### Issue # (if applicable)

Closes #31074.

### Reason for this change

Cloudformation supports for setting port number for the Neptune cluster but AWS CDK cannot do this.

### Description of changes

Add `port` prop to `DatabaseClusterProps`.

### Description of how you validated changes

Added both unit and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune-alpha): specify port for the cluster badmintoncryer/aws-cdk
2 participants
@badmintoncryer @ashishdhingra