Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(neptune-alpha): specify port for the cluster #31137

Merged
merged 12 commits into from
Sep 4, 2024
Merged

feat(neptune-alpha): specify port for the cluster #31137

merged 12 commits into from
Sep 4, 2024

Conversation

badmintoncryer
Copy link
Contributor

Issue # (if applicable)

Closes #31074.

Reason for this change

Cloudformation supports for setting port number for the Neptune cluster but AWS CDK cannot do this.

Description of changes

Add port prop to DatabaseClusterProps.

Description of how you validated changes

Added both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 18, 2024 02:04
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Aug 18, 2024
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Closed
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 20, 2024
go-to-k
go-to-k suggested changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems at all, but just very detailed comment.

packages/@aws-cdk/aws-neptune-alpha/lib/cluster.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 31, 2024
badmintoncryer and others added 2 commits September 1, 2024 08:40
@badmintoncryer @go-to-k
Update cluster.ts
3421853 
Co-authored-by: Kenta Goto (k.goto) <24818752+go-to-k@users.noreply.github.com>
@badmintoncryer
Merge branch 'main' into 31074-port
7bf4244
@badmintoncryer
Copy link
Contributor Author

Thank you @go-to-k !
I've updated JSdoc as you suggested.

@github-actions github-actions bot mentioned this pull request Sep 1, 2024
Open
go-to-k
go-to-k approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 1, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9951756
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 130b62b into aws:main Sep 4, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2024