Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tweaks for Ruby integration #1852

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

Ruby depends on some additional SSL flags and retrieving DH from EVP_PKEY_get0 with EVP_PKEY_DH (which were both recently added).
There were a couple test failures in test_cipher.rb that were relatively easy to fix.

❯ make test-all TESTS=../test/openssl/test_cipher.rb
config.status: creating ruby-runner.h
making mjit_build_dir.so
Run options: 
  --seed=38192
  "--ruby=./miniruby -I../lib -I. -I.ext/common  ../tool/runruby.rb --extout=.ext  -- --disable-gems"
  --excludes-dir=../test/excludes
  --name=!/memory_leak/

# Running tests:

Finished tests in 0.058507s, 324.7500 tests/s, 1982.6843 assertions/s.           
19 tests, 116 assertions, 0 failures, 0 errors, 0 skips

ruby -v: ruby 3.1.6p260 (2024-09-10 revision 30d00a0b43) [x86_64-linux]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner September 13, 2024 23:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.54%. Comparing base (c664abe) to head (3afb2c2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   78.56%   78.54%   -0.02%     
==========================================
  Files         583      583              
  Lines       98807    98809       +2     
  Branches    14161    14159       -2     
==========================================
- Hits        77623    77608      -15     
- Misses      20558    20573      +15     
- Partials      626      628       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit 998227d into aws:main Sep 17, 2024
110 checks passed
@samuel40791765 samuel40791765 deleted the minor-ruby-tweaks branch September 17, 2024 20:06
smittals2 added a commit that referenced this pull request Sep 19, 2024
## What's Changed
* More tweaks for Ruby integration by @samuel40791765 in
#1852
* Implementation of EVP_PKEY_CTX_ctrl_str for various key types by
@justsmth in #1850
* Add MLKEM768 Hybrid Groups to libssl by @alexw91 in
#1849
* add support for PEM_write_bio_PrivateKey_traditional by
@samuel40791765 in #1845
* Update s2n-bignum subtree by @torben-hansen in
#1861
* Add asserts in testing to fix Coverity alert by @smittals2 in
#1864
* Disable CRYPTO_is_AVX512IFMA_capable by @justsmth in
#1858


**Full Changelog**:
v1.35.0...v1.35.1

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants