Disable CRYPTO_is_AVX512IFMA_capable #1858
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1858 +/- ##
==========================================
- Coverage 78.46% 78.46% -0.01%
==========================================
Files 585 585
Lines 99457 99458 +1
Branches 14236 14237 +1
==========================================
- Hits 78038 78035 -3
- Misses 20784 20787 +3
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
CRYPTO_is_AVX512IFMA_capable
branch
from
078ae42
to
524cce9
Compare
It's hard to gauge the impact of this fix (or more importantly, it's absence) as a casual reader. Will using aws-lc 1.35.0 on some platforms potentially not benefit from AVX512 support until this fix lands? |
Correct, the new RSA AVX512 (IFMA) code in v1.35.0 doesn't actually get used due to this issue. Hopefully, we can release a v1.35.1 later today with this fix. (We plan to delay the release of aws-lc-rs until this fix can be included.) |
Great, thanks @justsmth 🙇 |
justsmth
force-pushed
the
CRYPTO_is_AVX512IFMA_capable
branch
3 times, most recently
from
c37fac4
to
ed1d2b2
Compare
justsmth
force-pushed
the
CRYPTO_is_AVX512IFMA_capable
branch
from
ed1d2b2
to
35e1a1c
Compare
justsmth
force-pushed
the
CRYPTO_is_AVX512IFMA_capable
branch
from
35e1a1c
to
9cff9f8
Compare
justsmth
changed the title
|
There are Intel SDE tests failing on Windows when AVX512IFMA usage is enabled. (All tests for Linux pass.) Prima facie, the failures appear to be unrelated, but we need time to understand the failures. |
## What's Changed * More tweaks for Ruby integration by @samuel40791765 in #1852 * Implementation of EVP_PKEY_CTX_ctrl_str for various key types by @justsmth in #1850 * Add MLKEM768 Hybrid Groups to libssl by @alexw91 in #1849 * add support for PEM_write_bio_PrivateKey_traditional by @samuel40791765 in #1845 * Update s2n-bignum subtree by @torben-hansen in #1861 * Add asserts in testing to fix Coverity alert by @smittals2 in #1864 * Disable CRYPTO_is_AVX512IFMA_capable by @justsmth in #1858 **Full Changelog**: v1.35.0...v1.35.1 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.