Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: append rather than truncate #76

Merged
merged 3 commits into from
Jul 19, 2023
Merged

log: append rather than truncate #76

merged 3 commits into from
Jul 19, 2023

Conversation

tamird
Copy link
Member

@tamird tamird commented Jul 19, 2023

No description provided.

Copy link
Member

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When passing `-Clink-arg=--log-file=path-to-file` to rustc through
cargo, it's likely that the linker is going to be used multiple times
concurrently.  This isn't ideal because the logs interleave; it would be
better to change the flag semantics to --log-dir so that each linker
instance can have its own log file, but that is left for another day.
@tamird tamird merged commit 6b40862 into main Jul 19, 2023
5 checks passed
@tamird tamird deleted the logging branch July 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants