Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: append rather than truncate #76

Merged
merged 3 commits into from
Jul 19, 2023
Merged

log: append rather than truncate #76

merged 3 commits into from
Jul 19, 2023

Commits on Jul 18, 2023

  1. Destructure earlier

    @tamird
    tamird committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    be95cae View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Reduce allocations

    @tamird
    tamird committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    dbee51a View commit details
    Browse the repository at this point in the history

  2. log: append rather than truncate 

    When passing `-Clink-arg=--log-file=path-to-file` to rustc through
cargo, it's likely that the linker is going to be used multiple times
concurrently.  This isn't ideal because the logs interleave; it would be
better to change the flag semantics to --log-dir so that each linker
instance can have its own log file, but that is left for another day.
    @tamird
    tamird committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c1716fb View commit details
    Browse the repository at this point in the history