BaseService tests: Use Chai #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
platan
reviewed
Jan 15, 2018
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| const assert = require('assert'); | |||
| const { expect } = require('chai'); | |||
| const sinon = require('sinon'); | |||
|
|
|||
There was a problem hiding this comment.
Adding require('../lib/register-chai-plugins.spec'); here allows to run tests only from this file (using command line or IDE). Otherwise we will get Error: Invalid Chai property: calledOnce ...
platan
reviewed
Jan 15, 2018
services/base.spec.js
Outdated
| assert(mockCamp.route.calledOnce); | ||
| assert.equal(mockCamp.route.getCall(0).args[0].toString(), expectedRouteRegex); | ||
| expect(mockCamp.route).to.have.been.calledOnce; | ||
| expect(mockCamp.route.getCall(0).args[0].toString()).to.equal(expectedRouteRegex.toString()); |
There was a problem hiding this comment.
Can we replace it with
expect(mockCamp.route).to.have.been.calledWith(expectedRouteRegex);There was a problem hiding this comment.
Unfortunately it fails, because we need the .toString().
> /foo/ === /foo/
false
> /foo/ == /foo/
false
> /foo/.toString() === /foo/.toString()
true
There was a problem hiding this comment.
Ha, no, you're right.
|
It looks great! Thanks :-) |
|
Thanks for reading 😄 |
paulmelnikow
added a commit
that referenced
this pull request
Mar 12, 2018
…1543 This merges the `node-8` branch. The heavy lift was by @Daniel15 with refactoring from me and a patch by @RedSparr0w. * New API for registering services (#963) * Disable Node 6 tests on node-8 branch (#1423) * BaseService: Factor out methods _regex and _namedParamsForMatch (#1425) - Adjust test grouping - Rename data -> queryParams, text -> message * BaseService tests: Use Chai (#1450) * BaseService: make serviceData and badgeData explicit and declarative (#1451) * fix isValidStyle test (#1544) * Run tests in Node 9, not Node 6 (#1543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.