Update server to Node 8 #1543
Merged
Update server to Node 8 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed commit: [f6cdac8] Oops, forgot server does not work in Node 9 [3046d79] Clear some more build errors [dbd12fc] Get lint passing with async/await [0a2deeb] Remove unneeded load-logos changes [1b9ae44] Code review comments, and add basic unit test [1593ea0] New API for registering services - v2
# Conflicts: # .travis.yml # package.json
- Adjust test grouping - Rename data -> queryParams, text -> message
|
Thanks!
Yea, that's what I'm feeling. IIRC there were some conflicts which would have to be solved again. I guess we could also squash. In the end, this is a pretty small diff. |
Generated by 🚫 dangerJS |
# Conflicts: # package.json
I need to reinstall Docker to build these images. This is going to fail in CI until I can do that.
|
Let's track the opens in #1358. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got word that the production servers are running Node 9.4.0! This is awesome!
Let's get our new service framework merged so we can plunge ahead with #1358.
Todos before merging (deploy blockers = merge blockers):
isValidStylehttps://circleci.com/gh/badges/shields/2840Todos after:
services/appveyor/appveyor.js(exports one or more services)services/appveyor/appveyor.tester.js(exports a ServiceTester)services/appveyor/appveyor.spec.js(describe()'s andit()'s for the helper functions, if any)check-node-versionflagsAnything we should add?
Also, I'm assuming we will merge this using a regular merge workflow to keep the history. Alternatively we could rebase this first, with a new, cleaner history. That'll be a bit of work, though. Thoughts?