Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add author filter option for [GithubCommitActivity] #9251

Merged
merged 14 commits into from
Jun 15, 2023

Commits on Jun 10, 2023

  1. feat: Add author filter option for CommitActivity

    Add a new filter option to [GithubCommitActivity], allowing users to filter the commit activity by a specific author.
    
    To make the filter more explicit, The label display "commits by [author]" for the total amount of commits and "commit activity by [author]" for other intervals when an author filter is selected.
    
    To maintain a clear and organized code structure, The filtered author is added as an argument and not to the shield path.
    
    The request to find the number of commits by the author is made using the REST api rather then the GraphQL api to make it in 1 request rather then 2.
    
    Resolves badges#9215
    jNullj committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    37dbc7a View commit details
    Browse the repository at this point in the history
  2. fix: solve eslint errors

    jNullj committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    71753a2 View commit details
    Browse the repository at this point in the history
  3. Add tests for [GithubCommitActivity] filter by author

    Add tests for the new filter by author feature.
    jNullj committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    998ea6f View commit details
    Browse the repository at this point in the history
  4. update [GithubCommitActivity] spec file for new author feat

    Add test for new transformAuthorFilter function of GithubCommitActivity added for the author filter feature.
    jNullj committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    ab006fc View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    43904a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6703fe6 View commit details
    Browse the repository at this point in the history
  3. improve error handeling for GithubCommitActivity

    The author filter error handling removed was redundent as it would never execute, there is no way to seperate branch not found from repo not found.
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    9e358c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b704300 View commit details
    Browse the repository at this point in the history
  5. update depricated functions

    PR badges#9233 replaced errorsMessages with httpErrors.
    This commit updates the new changes to stay up to date with that PR
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c2b5769 View commit details
    Browse the repository at this point in the history
  6. remove test for nonexisting error

    this exception was removed in commit 9e358c8 and is not needed anymore
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6b773c2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3c2ddcb View commit details
    Browse the repository at this point in the history
  8. Update example for GithubCommitActivity

    Picked a user with commits in the repo as an example that would work
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e60d71a View commit details
    Browse the repository at this point in the history
  9. Add test for invalid commit activity branch

    Add test for REST API calls in commit activity branch
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7b46dd9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    713374a View commit details
    Browse the repository at this point in the history