fix [github] service tests #9425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
keep-service-tests-green
chris48s
commented
Jul 31, 2023
| @@ -247,7 +247,7 @@ export default class GithubDownloads extends GithubAuthV3Service { | |||
| } | |||
|
|
|||
| if (releases.length === 0) { | |||
| throw new NotFound({ prettyMessage: 'no releases' }) | |||
| throw new NotFound({ prettyMessage: 'no releases found' }) | |||
There was a problem hiding this comment.
The issue here is that fetchLatestRelease() (which we also call in this service) throws "no releases found". I've brought the message for both services into line.
| @@ -8,4 +8,4 @@ t.create('hit counter') | |||
|
|
|||
| t.create('hit counter for nonexistent repo') | |||
| .get('/badges/puppets/async%20handle.json') | |||
| .expectBadge({ label: 'counter', message: 'repo not found' }) | |||
| .expectBadge({ label: 'async handle counter', message: '0' }) | |||
There was a problem hiding this comment.
This query no longer throws a 404 for repo doesn't exist - it just says zero results
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.